Cleanup patch 1 - fixes & features

[Patch date 2003-07-15 00:00]

Changes (against cleanup.0):

UploadQueue.cpp [CUploadQueue::Process()]

When uploadinglist is empty, before returning clear datarate list. If this is not done, UI will show uploading speed from when there was a slot even when no uploads are going on anymore. Rare case, but possible.

Download 1a

 

EMSocket.cpp [CEMSocket::Send()]

UploadClient.cpp [UpDownClient::SendBlockData()]

SLUGFILLER: noRefrag

Download 1b

 

DownloadQueue.cpp, DownloadQueue.h [CDownloadQueue::SavePartFilesToKnown(), CDownloadQueue::GetPartFilesCount()]

KnownFile.cpp, KnownFile.h [CFileStatistic::Merge()]

KnownFileList.cpp, KnownFileList.h [CKnownFileList::RemoveFile(), CKnownFileList::FilterDuplicateKnownFiles(), CKnownFileList::Save()]

PartFile.cpp, PartFile.h [CPartFile::WriteToFile(), CPartFile::LoadPartFile()]

SharedFileList.cpp [CSharedFileList::AddFilesFromDirectory(), CSharedFileList::SafeAddKFile(), CSharedFileList::RemoveFile()]

SLUGFILLER: mergeKnown

Download 1c

 

emuleDlg.cpp [CemuleDlg::ShowConnectionState(), CemuleDlg::SetActiveDialog(), CemuleDlg::OnCommand()]

MuleToolbarCtrl.h [enum TOOLBARBUTTONS]

MuleToolbarCtrl.cpp [CMuleToolbarCtrl::OnEraseBkgnd(), CMuleToolbarCtrl::Init()]

Toolbar button enumeration. The toolbar buttons were referred to as IDC_TOOLBARBUTTON + <magic number>. This patch enumerates the buttons and uses names instead of magic numbers. Numbering is now used only in CMuleToolbarCtrl::Localize() which uses an array and for-loop.

Download 1d

 

Coding style

Yes, I was foolish enought to think about it. After a few hours I just let the issue rest.. There is no style in the code, and by trying to modify the files to match some coding style, I'd just make it harder for myself to diff against official tree.

Downloads:

Changed files (against cleanup.0)

Full sources